Run tests on all platforms #208
Conversation
…nda-forge-pinning 2024.02.01.06.13.37 Signed-off-by: Marcel Bargull <[email protected]>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
mbargull
force-pushed
the
1.x-windows-tests
branch
3 times, most recently
from
ad77bdb to
d2fdd96
Compare
Signed-off-by: Marcel Bargull <[email protected]>
As of now, one would need to add the conda-forge/label/cf201901 to install python=2.7 on Windows, see conda-forge/python-feedstock#637 . Now in 2024, it should be fine if we just test with another old version. Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
1.x-windows-tests
branch
from
0b54bd2 to
0bcbf8e
Compare
| - cmd /q /c "for /f "delims=" %%f in ('C:\Windows\System32\where mamba.exe') do if "%%~dpf"=="%SCRIPTS%\" (exit 0) else (exit 1)" # [win] | ||
|
|
||
| # We need to run with "call" on Windows since "mamba" runs the batch file; make "call" a passthrough function on Unixes. | ||
| - call() { "${@}" ; } # [unix] |
There was a problem hiding this comment.
Defining this pass-through function here allows us to have the test below uniform on all platform so we can avoid duplication and overall maintenance burden.
|
|
||
| # Ensure we run the executable from the prefix and not from the base installation. | ||
| - test "$(command -v mamba)" = "${PREFIX}/bin/mamba" # [unix] | ||
| - cmd /q /c "for /f "delims=" %%f in ('C:\Windows\System32\where mamba.bat') do if "%%~dpf"=="%LIBRARY_BIN%\" (exit 0) else (exit 1)" # [win] |
There was a problem hiding this comment.
This cryptic Batch nonsense should be equivalent to the POSIX shell test above it and checks that the first entry on PATH with the executable is the one we want to test.
It's wrapped in a cmd /c call since we have an exit 0 in there (to only check the first entry) which would exit the whole test script if it wasn't wrapped in a subprocess.
I tried to use findstr "/C:%PREFIX%" in there, but it turns out that the search strings for findstr are length-limited far below the PREFIX' lengths we use.
| # We need to run with "call" on Windows since "mamba" runs the batch file; make "call" a passthrough function on Unixes. | ||
| - call() { "${@}" ; } # [unix] | ||
| - call mamba --help | ||
| - call mamba create -n test_py37 python=3.7 --dry-run |
There was a problem hiding this comment.
python=2.7 can't be installed on Windows anymore since vc=9 is on the cf201901 label.
We'd have to use that label (or defaults, I guess) in there to make it work.
But... we could also just not care too much about python=2.7 anymore and use another (by now old) version.
mbargull
requested review from
AntoinePrv,
JohanMabille,
SylvainCorlay,
adriendelsalle,
ericmjl and
wolfv
as code owners
|
As reported in mamba-org/mamba#3033 (comment) and mamba-org/mamba#3033 (comment) , this has some problems with only
This happens on all tested platforms for the Unfortunately, it also does not seem to emit non-zero exit codes in the failure cases, which is why the tests in this feedstock didn't catch this. |
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
|
Hi @mbargull, are you still working on this PR? |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)